On Sun, Dec 08, 2024 at 09:23:27AM -0600, Joel Selvaraj wrote: > In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech > FT8719 touchscreen is integrally connected to the display panel > (EBBG FT8719) and thus should be power sequenced together with display > panel for proper functioning. Add the panel property which optionally > allows to link panel to the touchscreen. > > Signed-off-by: Joel Selvaraj <foss@xxxxxxxxxxxxxxxx> SoB mismatch. Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > index 70a922e213f2a..35a6ac4ded7c7 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > @@ -103,6 +103,7 @@ properties: > minimum: 0 > maximum: 255 > > + panel: true So you just list all properties from touchscreen... no, use unevaluatedProperties instead of additionalProperties. Best regards, Krzysztof
