On Fri, Dec 06, 2024 at 11:12:58AM +0100, Neil Armstrong wrote: > The dlg,const-op-mode & dlg,periodic-op-mode were mis-names with twice > the "dlg," prefix, drop one to match the bindings. > > This fixes: > sm8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,const-op-mode' is a required property > from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml# > m8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,periodic-op-mode' is a required property > from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml# > sm8150-microsoft-surface-duo.dtb: da7280@4a: 'dlg,dlg,const-op-mode', 'dlg,dlg,periodic-op-mode' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/input/dlg,da7280.yaml# > > With the dlg,da7280.yaml converted from dlg,da7280.txt at [1]. > > [1] https://lore.kernel.org/all/20241206-topic-misc-da7280-convert-v2-1-1c3539f75604@xxxxxxxxxx/ > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Fixes: d1f781db47a8 ("arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts > index b039773c44653ae8cd5c2b9fdeccbd304ad2c9e5..a1323a8b8e6bfb556a2d6d865f8b560bd6c4d429 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts > +++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts > @@ -376,8 +376,8 @@ da7280@4a { > pinctrl-0 = <&da7280_intr_default>; > > dlg,actuator-type = "LRA"; > - dlg,dlg,const-op-mode = <1>; > - dlg,dlg,periodic-op-mode = <1>; > + dlg,const-op-mode = <1>; > + dlg,periodic-op-mode = <1>; > dlg,nom-microvolt = <2000000>; > dlg,abs-max-microvolt = <2000000>; > dlg,imax-microamp = <129000>; > > -- > 2.34.1 > -- With best wishes Dmitry