Re: [PATCH v4 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC

[Joey Lu <a0987203069@xxxxxxxxx>]

Dear Rob,

Thank you for your reply.

Rob Herring 於 12/4/2024 10:27 PM 寫道:
> On Mon, Dec 02, 2024 at 10:36:41AM +0800, Joey Lu wrote:
> > Create initial schema for Nuvoton MA35 family Gigabit MAC.
> >
> > Signed-off-by: Joey Lu <a0987203069@xxxxxxxxx>
> > ---
> >   .../bindings/net/nuvoton,ma35d1-dwmac.yaml    | 134 ++++++++++++++++++
> >   .../devicetree/bindings/net/snps,dwmac.yaml   |   1 +
> >   2 files changed, 135 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
> > new file mode 100644
> > index 000000000000..e44abaf4da3e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
> > @@ -0,0 +1,134 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/nuvoton,ma35d1-dwmac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton DWMAC glue layer controller
> > +
> > +maintainers:
> > +  - Joey Lu <yclu4@xxxxxxxxxxx>
> > +
> > +description:
> > +  Nuvoton 10/100/1000Mbps Gigabit Ethernet MAC Controller is based on
> > +  Synopsys DesignWare MAC (version 3.73a).
> > +
> > +allOf:
> > +  - $ref: snps,dwmac.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nuvoton,ma35d1-dwmac
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      Register range should be one of the GMAC interface.
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: MAC clock
> > +      - description: PTP clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: stmmaceth
> > +      - const: ptp_ref
> > +
> > +  nuvoton,sys:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    items:
> > +      - items:
> > +          - description: phandle to access syscon registers.
> > +          - description: GMAC interface ID.
> > +            enum:
> > +              - 0
> > +              - 1
> > +    description:
> > +      A phandle to the syscon with one argument that configures system registers
> > +      for MA35D1's two GMACs. The argument specifies the GMAC interface ID.
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  reset-names:
> > +    items:
> > +      - const: stmmaceth
> > +
> > +  phy-mode:
> > +    enum:
> > +      - rmii
> > +      - rgmii
> > +      - rgmii-id
> > +      - rgmii-txid
> > +      - rgmii-rxid
> > +
> > +  tx-internal-delay-ps:
> > +    default: 0
> > +    minimum: 0
> > +    maximum: 2000
> > +    description:
> > +      RGMII TX path delay used only when PHY operates in RGMII mode with
> > +      internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds.
> > +      Allowed values are from 0 to 2000.
> > +
> > +  rx-internal-delay-ps:
> > +    default: 0
> > +    minimum: 0
> > +    maximum: 2000
> > +    description:
> > +      RGMII RX path delay used only when PHY operates in RGMII mode with
> > +      internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds.
> > +      Allowed values are from 0 to 2000.
> > +
> > +  mdio:
> > +    $ref: /schemas/net/mdio.yaml#
> Drop. snps,dwmac.yaml already has this.
Got it.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - interrupt-names
> Drop all 4. Already required by snps,dwmac.yaml.
Got it.
> > +  - clocks
> > +  - clock-names
> > +  - nuvoton,sys
> > +  - resets
> > +  - reset-names
> > +  - phy-mode
> Drop this one too.
Got it.
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
> > +    #include <dt-bindings/reset/nuvoton,ma35d1-reset.h>
> > +    ethernet@40120000 {
> > +        compatible = "nuvoton,ma35d1-dwmac";
> > +        reg = <0x40120000 0x10000>;
> > +        interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > +        interrupt-names = "macirq";
> > +        clocks = <&clk EMAC0_GATE>, <&clk EPLL_DIV8>;
> > +        clock-names = "stmmaceth", "ptp_ref";
> > +
> > +        nuvoton,sys = <&sys 0>;
> > +        resets = <&sys MA35D1_RESET_GMAC0>;
> > +        reset-names = "stmmaceth";
> > +
> > +        phy-mode = "rgmii-id";
> > +        phy-handle = <&eth_phy0>;
> > +        mdio {
> > +            compatible = "snps,dwmac-mdio";
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            ethernet-phy@0 {
> > +                reg = <0>;
> > +            };
> > +        };
> > +    };
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index eb1f3ae41ab9..4bf59ab910cc 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -67,6 +67,7 @@ properties:
> >           - ingenic,x2000-mac
> >           - loongson,ls2k-dwmac
> >           - loongson,ls7a-dwmac
> > +        - nuvoton,ma35d1-dwmac
> >           - qcom,qcs404-ethqos
> >           - qcom,sa8775p-ethqos
> >           - qcom,sc8280xp-ethqos
> > --
> > 2.34.1

Thanks!

BR,

Joey