On Mon, Nov 04, 2024 at 09:40:59AM -0600, Rob Herring wrote:
> On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote:
> > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint'
> > property referencing video-interfaces.yaml. Allow 'data-lanes' values
> > 1, 2, 3, and 4 for port@1.
>
> Describe "why", not what the changes are. I can read the diff. Why is
> the IP has a configurable number of lanes...
How about
"This controller support scalable data lanes from 1 to 4. Add the
'data-lanes' property to configure the number of MIPI display panel lanes
selected for boards."
Frank
>
> >
> > Fix below CHECK_DTB warnings:
> > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb:
> > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> > index 350fb8f400f02..5952e6448ed47 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> > @@ -111,11 +111,27 @@ properties:
> > unevaluatedProperties: false
> >
> > port@1:
> > - $ref: /schemas/graph.yaml#/properties/port
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > description:
> > DSI output port node to the panel or the next bridge
> > in the chain
> >
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + data-lanes:
> > + description: array of physical DSI data lane indexes.
> > + minItems: 1
> > + items:
> > + - const: 1
> > + - const: 2
> > + - const: 3
> > + - const: 4
> > +
> > required:
> > - port@0
> > - port@1
> > --
> > 2.34.1
> >
