On 05/12/2024 13:29, Heiko Stübner wrote: > Hi Krzysztof, > > Am Donnerstag, 5. Dezember 2024, 11:25:28 CET schrieb Krzysztof Kozlowski: >> On Thu, Dec 05, 2024 at 02:50:46AM -0300, Val Packett wrote: >>> RK3066 does have two "CIF" video capture interface blocks, add their >>> corresponding clock IDs so that they could be used. >>> >>> Signed-off-by: Val Packett <val@xxxxxxxxxxxx> >>> --- >>> drivers/clk/rockchip/clk-rk3188.c | 4 ++-- >>> include/dt-bindings/clock/rk3188-cru-common.h | 2 ++ >>> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> Please run scripts/checkpatch.pl and fix reported warnings. Then please >> run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. >> Some warnings can be ignored, especially from --strict run, but the code >> here looks like it needs a fix. Feel free to get in touch if the warning >> is not clear. > > I guess you're taking a shot of the indentation? No, there is a big, fat warning about bindings. Best regards, Krzysztof
