Hi, Wolfram,
On 20.11.2024 10:49, Wolfram Sang wrote:
> Enable I2C1 for the carrier board and the connected power monitor
> ISL28022. Limit the bus speed to the maximum the power monitor supports.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> i2c1 gets enabled in the current SoM-DTSI as well, but to be safe
> regarding other SoM DTSIs to come, I opted for explicitly enabling it in
> the carrier board as well.
>
> I picked the 'average-samples' value using my gut feeling. If someone
> has a reason to pick a better one, I am all for it.
>
> arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> index 7945d44e6ee1..5e4bfaeafd20 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -73,6 +73,19 @@ &i2c0 {
> clock-frequency = <1000000>;
> };
>
> +&i2c1 {
> + status = "okay";
> +
> + clock-frequency = <400000>;
This could be moved before status to comply with [1]. I can take care of it
later as I failed to follow [1] for i2c0 as well.
Other than this:
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
I gave it a try on RZ/G3S:
Tested-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
Thank you,
Claudiu
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n112
> +
> + power-monitor@44 {
> + compatible = "renesas,isl28022";
> + reg = <0x44>;
> + shunt-resistor-micro-ohms = <8000>;
> + renesas,average-samples = <32>;
> + };
> +};
> +
> &pinctrl {
> key-1-gpio-hog {
> gpio-hog;
