Re: [PATCH v2 17/18] arm64: dts: mediatek: mt7988: enable ssusb1 on bpi-r4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 2024-12-03 10:40, schrieb AngeloGioacchino Del Regno:
Il 02/12/24 13:25, Frank Wunderlich ha scritto:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

Enable front-usb on Bananapi R4 board.

Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

thanks, but i noticed, that the controllers in dtsi are not disabled like in my final dtsi. Imho controllers should be disabled by default and only enabled when used on board. Should i add disabling in this patch too?

and i noticed that usb phys have to be added to get working usb. Here for ssusb1 a tphy is used where i now have prepared patch so i can add it in next version (reusing mt7986 compatible). ssusb0 uses a different phy (xsphy) which needs a bit more work before (driver and binding change).

regards Frank




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux