If there's going to be another version (to fix this) ... On Wed Dec 4, 2024 at 3:16 AM CET, Kever Yang wrote: > On 2024/12/4 00:54, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@xxxxxxxxx> > > > > This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and > > enables its use on the RK3588. > > > > Right now the DSI2 controller is always paired with a DC-phy based on a > > Samsung IP, so the interface values are set statically for now. > > This stays true for the upcoming RK3576 as well. > > > > Tested-by: Daniel Semkowicz <dse@xxxxxxxxxxxxx> > > Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxxxxx> > > --- > > drivers/gpu/drm/rockchip/Kconfig | 10 + > > drivers/gpu/drm/rockchip/Makefile | 1 + > > .../gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c | 524 ++++++++++++++++++ > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 + > > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + > > 5 files changed, 538 insertions(+) > > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > > index 448fadd4ba15..84af423b7f90 100644 > > --- a/drivers/gpu/drm/rockchip/Kconfig > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > @@ -10,6 +10,7 @@ config DRM_ROCKCHIP > > select DRM_DW_HDMI if ROCKCHIP_DW_HDMI > > select DRM_DW_HDMI_QP if ROCKCHIP_DW_HDMI_QP > > select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI > > + select DRM_DW_MIPI_DSI2 if ROCKCHIP_DW_MIPI_DSI2 > > select GENERIC_PHY if ROCKCHIP_DW_MIPI_DSI > > select GENERIC_PHY_MIPI_DPHY if ROCKCHIP_DW_MIPI_DSI > > select SND_SOC_HDMI_CODEC if ROCKCHIP_CDN_DP && SND_SOC > > @@ -81,6 +82,15 @@ config ROCKCHIP_DW_MIPI_DSI > > enable MIPI DSI on RK3288 or RK3399 based SoC, you should > > select this option. > > > > +config ROCKCHIP_DW_MIPI_DSI2 > > + bool "Rockchip specific extensions for Synopsys DW MIPI DSI2" > > + select GENERIC_PHY_MIPI_DPHY > > + help > > + This selects support for Rockchip SoC specific extensions > > + for the Synopsys DesignWare dsi driver. If you want to ... could you then also s/dsi/DSI/ ? Cheers, Diederik > > + enable MIPI DSI on RK3576 or RK3588 based SoC, you should > > + select this option. > > + > > config ROCKCHIP_INNO_HDMI > > bool "Rockchip specific extensions for Innosilicon HDMI" > > select DRM_DISPLAY_HDMI_HELPER > > diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockchip/Makefile > > index 3eab662a5a1d..2b867cebbc12 100644 > > --- a/drivers/gpu/drm/rockchip/Makefile > > +++ b/drivers/gpu/drm/rockchip/Makefile > > @@ -13,6 +13,7 @@ rockchipdrm-$(CONFIG_ROCKCHIP_CDN_DP) += cdn-dp-core.o cdn-dp-reg.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_HDMI_QP) += dw_hdmi_qp-rockchip.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_MIPI_DSI) += dw-mipi-dsi-rockchip.o > > +rockchipdrm-$(CONFIG_ROCKCHIP_DW_MIPI_DSI2) += dw-mipi-dsi2-rockchip.o > > rockchipdrm-$(CONFIG_ROCKCHIP_INNO_HDMI) += inno_hdmi.o > > rockchipdrm-$(CONFIG_ROCKCHIP_LVDS) += rockchip_lvds.o > > rockchipdrm-$(CONFIG_ROCKCHIP_RGB) += rockchip_rgb.o > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > new file mode 100644 > > index 000000000000..55eed4001634 > > --- /dev/null > > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > @@ -0,0 +1,524 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (C) 2024 Rockchip Electronics Co.Ltd > This should be: > > Rockchip Electronics Co., Ltd. > > This typo is from vendor kernel, we will correct all this kind of issue locally, > and Andy is going to correct other files in drm for mainline kernel. > > Thanks, > - Kever
Attachment:
signature.asc
Description: PGP signature
