Hi, Angelo:
On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Add support for the newer HDMI-TX (Encoder) v2 and DDC v2 IPs
> found in MediaTek's MT8195, MT8188 SoC and their variants, and
> including support for display modes up to 4k60 and for HDMI
> Audio, as per the HDMI 2.0 spec.
>
> HDCP and CEC functionalities are also supported by this hardware,
> but are not included in this commit.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
[snip]
> +static const struct drm_edid *mtk_hdmi_v2_bridge_edid_read(struct drm_bridge *bridge,
> + struct drm_connector *connector)
> +{
This function is identical to v1, so make edid read as common function.
Regards,
CK
> + struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge);
> + const struct drm_edid *drm_edid;
> +
> + if (!hdmi->ddc_adpt)
> + return NULL;
> +
> + drm_edid = drm_edid_read_ddc(connector, hdmi->ddc_adpt);
> + if (drm_edid) {
> + /*
> + * This should use !connector->display_info.has_audio (or
> + * !connector->display_info.is_hdmi) from a path that has read
> + * the EDID and called drm_edid_connector_update().
> + */
> + const struct edid *edid = drm_edid_raw(drm_edid);
> +
> + hdmi->dvi_mode = !drm_detect_monitor_audio(edid);
> + }
> +
> + return drm_edid;
> +}
> +
>
