On Tue, Dec 03, 2024 at 05:49:31PM +0100, Heiko Stuebner wrote: > +properties: > + compatible: > + enum: > + - rockchip,rk3576-mipi-dcphy > + - rockchip,rk3588-mipi-dcphy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + description: | > + Argument is mode to operate in. Supported modes are: > + - PHY_TYPE_DPHY > + - PHY_TYPE_CPHY > + See include/dt-bindings/phy/phy.h for constants. That's the only difference from version I gave review. It is approved style of passing phy type/mode, so adding this is not valid reason to drop my review tag and request re-review. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof