On 30 March 2015 at 16:46, Suman Tripathi <stripathi@xxxxxxx> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@xxxxxxx> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Thu, Apr 9, 2015 at 9:40 PM, Suman Tripathi <stripathi@xxxxxxx> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi@xxxxxxx> wrote: >> This patch adds some quirks support to be read from fdt. >> >> Signed-off-by: Suman Tripathi <stripathi@xxxxxxx> >> --- >> drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-pltfm.c >> b/drivers/mmc/host/sdhci-pltfm.c >> index bef250e..9f6a4b9 100644 >> --- a/drivers/mmc/host/sdhci-pltfm.c >> +++ b/drivers/mmc/host/sdhci-pltfm.c >> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> *pdev) >> >> if (of_get_property(np, "broken-cd", NULL)) >> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + >> + if (of_get_property(np, "delay-after-power", NULL)) >> + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> + >> + if (of_get_property(np, "no-hispd", NULL)) >> + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> + >> + if (of_get_property(np, "broken-adma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> + >> + if (of_get_property(np, "broken-dma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> + >> + if (of_get_property(np, "no-cmd23", NULL)) >> + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > We are using arasan controller in our SOC. So reusing a the existing > sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us > only option left to pass the info is DTS or ACPI table. > > Kind regards > Uffe > > On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> >> On 30 March 2015 at 16:46, Suman Tripathi <stripathi@xxxxxxx> wrote: >> > This patch adds some quirks support to be read from fdt. >> > >> > Signed-off-by: Suman Tripathi <stripathi@xxxxxxx> >> > --- >> > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/drivers/mmc/host/sdhci-pltfm.c >> > b/drivers/mmc/host/sdhci-pltfm.c >> > index bef250e..9f6a4b9 100644 >> > --- a/drivers/mmc/host/sdhci-pltfm.c >> > +++ b/drivers/mmc/host/sdhci-pltfm.c >> > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> > *pdev) >> > >> > if (of_get_property(np, "broken-cd", NULL)) >> > host->quirks |= >> > SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> > + >> > + if (of_get_property(np, "delay-after-power", NULL)) >> > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> > + >> > + if (of_get_property(np, "no-hispd", NULL)) >> > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> > + >> > + if (of_get_property(np, "broken-adma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> > + >> > + if (of_get_property(np, "broken-dma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> > + >> > + if (of_get_property(np, "no-cmd23", NULL)) >> > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; >> >> Can't at least some of these be distinguished from what sdhci variant >> that is being used? Instead of having them in DT... >> >> Kind regards >> Uffe >> >> > >> > if (of_get_property(np, "no-1-8-v", NULL)) >> > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; >> > -- >> > 1.8.2.1 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> > the body of a message to majordomo@xxxxxxxxxxxxxxx >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Thanks, > with regards, > Suman Tripathi -- Thanks, with regards, Suman Tripathi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
