Hello,
On Mon, Dec 02, 2024 at 09:47:58PM +0100, Christian Marangi wrote:
> On Mon, Dec 02, 2024 at 09:38:10PM +0100, Uwe Kleine-König wrote:
> > hello,
> >
> > On Mon, Dec 02, 2024 at 04:12:04PM +0100, Christian Marangi wrote:
> > > +static struct platform_driver airoha_cpufreq_driver = {
> > > + .probe = airoha_cpufreq_probe,
> > > + .remove_new = airoha_cpufreq_remove,
> >
> > That doesn't build on top of mainline since commit e70140ba0d2b ("Get rid of 'remove_new' relic from platform driver struct")
> >
> > Please use .remove.
>
> Hi Uwe,
> I rebased this on top of next and still compiled but yes sorry it's a
> leftover from testing this also on my OpenWrt buildroot. (seems the
> commit still needs to be merged)
The relevant commits are:
- Since v6.3-rc1~106^2~108 ("platform: Provide a remove callback that
returns no value") there is .remove_new()
- Since v6.11-rc1~49^2~37^2 ("platform: Make platform_driver::remove()
return void") the prototype of .remove() changed to return void
- Since e70140ba0d2b ("Get rid of 'remove_new' relic from platform
driver struct") (which is currently only in Linus Torvalds repo and
probably in next starting today) .remove_new is gone.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature
