On Mon, Dec 02, 2024 at 01:09:12PM +0530, Taniya Das wrote: > > > On 12/2/2024 9:55 AM, Bjorn Andersson wrote: > > On Fri, Nov 08, 2024 at 09:39:17AM +0530, Taniya Das wrote: > > > Add support for multimedia clock controllers on Qualcomm QCS615 platform. > > > Update the defconfig to enable these clock controllers. > > > > > > Global clock controller support > > > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@xxxxxxxxxxx/ > > > > > > Signed-off-by: Taniya Das<quic_tdas@xxxxxxxxxxx> > > Dropping this series from my queue, due to lack of response from author. > > > > Taniya, please answer questions/feedback from Dmitry, Vladimir and > > Bryan, and repose as necessary. > > Sure, Bjorn, I had a dependency on the GCC patch. > > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@xxxxxxxxxxx/ > > I will fix the comments once the Global clock controller patch is picked. I think this makes a good generic feedback (I observe the antipattern in other engineer's behaviour too): please try responding to the comment after receiving it, not just before getting back to the series. For this particular case: there is no need to wait on GCC. Please stop using the external dt-bindings header and use <&gcc_foo_clock> instead. This is just an example, not a c&p from the platform's DT. -- With best wishes Dmitry
