Re: [PATCH v3 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver

[Taniya Das <quic_tdas@xxxxxxxxxxx>]

On 11/9/2024 10:52 PM, Bryan O'Donoghue wrote:
> On 08/11/2024 04:09, Taniya Das wrote:
> > +static struct gdsc vcodec0_gdsc = {
> > +    .gdscr = 0x874,
> > +    .en_rest_wait_val = 0x2,
> > +    .en_few_wait_val = 0x2,
> > +    .clk_dis_wait_val = 0x6,
> > +    .pd = {
> > +        .name = "vcodec0_gdsc",
> > +    },
> > +    .pwrsts = PWRSTS_OFF_ON,
> > +    .flags = HW_CTRL_TRIGGER | POLL_CFG_GDSCR,
> > +};
> > +
> > +static struct gdsc venus_gdsc = {
> > +    .gdscr = 0x814,
> > +    .en_rest_wait_val = 0x2,
> > +    .en_few_wait_val = 0x2,
> > +    .clk_dis_wait_val = 0x6,
> > +    .pd = {
> > +        .name = "venus_gdsc",
> > +    },
> > +    .pwrsts = PWRSTS_OFF_ON,
> > +    .flags = POLL_CFG_GDSCR,
> > +};
> > +
>
> This looks good to me, except; could you please check if venus gdsc 
> should be the parent of vcodec0.

For the video gdscs we generally do not explicitly need to mention the 
parent GDSC.

--
Thanks & Regards,
Taniya Das.