Re: [PATCH v2 0/4] arm64: dts: rockchip: cosmetic changes for Radxa ROCK 5B

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Fukaumi,

On 2024-12-02 03:32, FUKAUMI Naoki wrote:
this patch series sort nodes and properties, remove redundant
properties, and minor cosmetic changes.

no functional change is intended.

this patch series depend on following patch series:
 "arm64: dts: rockchip: sync dts with schematic for Radxa ROCK 5B"

https://patchwork.kernel.org/project/linux-rockchip/cover/20241130004057.7432-1-naoki@xxxxxxxxx/

FUKAUMI Naoki (4):
  arm64: dts: rockchip: sort nodes in .dts for Radxa ROCK 5B
  arm64: dts: rockchip: sort nodes in root node for Radxa ROCK 5B
  arm64: dts: rockchip: sort properties in .dts for Radxa ROCK 5B
  arm64: dts: rockchip: cosmetic changes for Radxa ROCK 5B

 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 184 ++++++++----------
 1 file changed, 86 insertions(+), 98 deletions(-)

I'd suggest that you expand the descriptions of all four patches
in this series.  The way they're currently written leaves a lot of
room for improvement, such as turning them into proper sentences
and expanding the wording to describe the intent and nature of the
introduced changes better.

The cover letter surely provides an additional explanation for
the entire series, but please note that only the patch descriptions
can find their way into the repository, so each patch description
needs to be self-contained and independent of the cover letter and
the descriptions of other patches in the series.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux