On Thu, 28 Nov 2024 20:32:45 +0100
Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:
> Add support for the regulators described in the dt-binding.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
> ---
> drivers/iio/chemical/bme680_core.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 9783953e64e0..186e0a6cc2d7 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c
> @@ -15,6 +15,7 @@
> #include <linux/log2.h>
> #include <linux/module.h>
> #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
>
> #include <linux/iio/buffer.h>
> #include <linux/iio/iio.h>
> @@ -111,6 +112,10 @@ enum bme680_scan {
> BME680_GAS,
> };
>
> +static const char *const bme680_supply_names[] = { "vdd", "vddio" };
> +
> +#define BME680_NUM_SUPPLIES ARRAY_SIZE(bme680_supply_names)
Trivial: What benefit do we get from this define that is used in one place?
> +
> struct bme680_data {
> struct regmap *regmap;
> struct bme680_calib bme680;
> @@ -1114,6 +1119,14 @@ int bme680_core_probe(struct device *dev, struct regmap *regmap,
> data->heater_dur = 150; /* milliseconds */
> data->preheat_curr_mA = 0;
>
> + ret = devm_regulator_bulk_get_enable(dev, BME680_NUM_SUPPLIES,
ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(bme680_supply_names),
bme680_supply_names);
And don't worry about slightly over 80 chars line.
> + bme680_supply_names);
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "failed to get and enable supplies.\n");
> +
> + fsleep(BME680_STARTUP_TIME_US);
> +
> ret = regmap_write(regmap, BME680_REG_SOFT_RESET, BME680_CMD_SOFTRESET);
> if (ret < 0)
> return dev_err_probe(dev, ret, "Failed to reset chip\n");
