Hi Greg, On 14:46 Mon 25 Nov , Greg Kroah-Hartman wrote: > On Sun, Nov 24, 2024 at 11:51:45AM +0100, Andrea della Porta wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2611,6 +2611,9 @@ > > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > > > +#define PCI_VENDOR_ID_RPI 0x1de4 > > +#define PCI_DEVICE_ID_RPI_RP1_C0 0x0001 > > As you only use these in one file, please read the top of this file for > why this isn't needed here, but rather should be back in that one > driver. The reason I've defined them in pci_ids.h is due to the fact that they are indeed used both by the driver (drivers/misc/rp1/rp1_pci.c) and in drivers/pci/quirks.c. Many thanks, Andrea > > thanks, > > greg k-h
