RE: [PATCH 04/12] dt-bindings: clock: renesas: Document RZ/G3E SoC CPG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Conor and Geert,

> -----Original Message-----
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Sent: 22 November 2024 12:46
> Subject: [PATCH 04/12] dt-bindings: clock: renesas: Document RZ/G3E SoC CPG
> 
> Document the device tree bindings for the Renesas RZ/G3E SoC Clock Pulse Generator (CPG).
> 
> Also define constants for the core clocks of the RZ/G3E SoC.
> 
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
>  .../bindings/clock/renesas,rzv2h-cpg.yaml     | 15 +++++++------
>  .../dt-bindings/clock/renesas,r9a09g047-cpg.h | 21 +++++++++++++++++++
>  2 files changed, 30 insertions(+), 6 deletions(-)  create mode 100644 include/dt-
> bindings/clock/renesas,r9a09g047-cpg.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> index 926c503bed1f..c3fe76abd549 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> @@ -4,19 +4,22 @@
>  $id: http://devicetree.org/schemas/clock/renesas,rzv2h-cpg.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> 
> -title: Renesas RZ/V2H(P) Clock Pulse Generator (CPG)
> +title: Renesas RZ/{G3E,V2H(P)} Clock Pulse Generator (CPG)
> 
>  maintainers:
>    - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
>  description:
> -  On Renesas RZ/V2H(P) SoCs, the CPG (Clock Pulse Generator) handles generation
> -  and control of clock signals for the IP modules, generation and control of resets,
> -  and control over booting, low power consumption and power supply domains.
> +  On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator)
> + handles  generation and control of clock signals for the IP modules,
> + generation and  control of resets, and control over booting, low power
> + consumption and power  supply domains.
> 
>  properties:
>    compatible:
> -    const: renesas,r9a09g057-cpg
> +    enum:
> +      - renesas,r9a09g047-cpg # RZ/G3E
> +      - renesas,r9a09g057-cpg # RZ/V2H
> 
>    reg:
>      maxItems: 1
> @@ -37,7 +40,7 @@ properties:
>      description: |
>        - For CPG core clocks, the two clock specifier cells must be "CPG_CORE"
>          and a core clock reference, as defined in
> -        <dt-bindings/clock/renesas,r9a09g057-cpg.h>,
> +        <dt-bindings/clock/renesas,r9a09g0*-cpg.h>,
>        - For module clocks, the two clock specifier cells must be "CPG_MOD" and
>          a module number.  The module number is calculated as the CLKON register
>          offset index multiplied by 16, plus the actual bit in the register diff --git a/include/dt-
> bindings/clock/renesas,r9a09g047-cpg.h b/include/dt-bindings/clock/renesas,r9a09g047-cpg.h
> new file mode 100644
> index 000000000000..5bcab7ca2bfc
> --- /dev/null
> +++ b/include/dt-bindings/clock/renesas,r9a09g047-cpg.h
> @@ -0,0 +1,21 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * Copyright (C) 2024 Renesas Electronics Corp.
> + */
> +#ifndef __DT_BINDINGS_CLOCK_RENESAS_R9A09G047_CPG_H__
> +#define __DT_BINDINGS_CLOCK_RENESAS_R9A09G047_CPG_H__
> +
> +#include <dt-bindings/clock/renesas-cpg-mssr.h>
> +
> +/* Core Clock list */
> +#define R9A09G047_SYS_0_PCLK			0
> +#define R9A09G047_CA55_0_CORE_CLK0		1
> +#define R9A09G047_CA55_0_CORE_CLK1		2
> +#define R9A09G047_CA55_0_CORE_CLK2		3
> +#define R9A09G047_CA55_0_CORE_CLK3		4

Typo here based on the based on "RZG3E_ClockList_rev1.0_na.xlsx"
CORE_CLK*-> CORECLK*

I will fix this while sending v2.

Cheers,
Biju





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux