Hi Krzysztof,
Thanks for the review
> > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Bhavin Sharma <bhavin.sharma@xxxxxxxxxxxxxxxxx>
>
> Your SoBs are odd... second patch has totally reversed path comparing to
> this one. What do you want to express here?
i will correct the order
> > + sense-resistor:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: Current sense resistor in milliohms
>
> phandle cannot be in milliohms... Anyway, use existing widely used
> property: shunt-resistor-micro-ohms
okay
> > + bat: battery {
> > + compatible = "simple-battery";
> > + charge-full-design-microamp-hours = <2600000>;
> > + voltage-min-design-microvolt = <3300000>;
> > + voltage-max-design-microvolt = <4250000>;
> > + };
>
> Drop battery node, not needed for example.
okay
> > + battery@70 {
> > + compatible = "st,stc3117";
> > + reg = <0x70>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
>
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.
ohh yes , need to add bindings for interrupt
Best Regards,
Bhavin
