Hi Uwe, Thanks for the feedback. > -----Original Message----- > From: Uwe Kleine-König <ukleinek@xxxxxxxxxx> > Sent: 29 November 2024 08:51 > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Subject: Re: [PATCH v22 1/4] dt-bindings: pwm: Add RZ/G2L GPT binding > > On Fri, Oct 18, 2024 at 02:00:42PM +0100, Biju Das wrote: > > .../bindings/pwm/renesas,rzg2l-gpt.yaml | 378 ++++++++++++++++++ > > 1 file changed, 378 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > > Wow, quite a big binding. An astonishing amount of irqs. > > > [...] > > + '#pwm-cells': > > + const: 2 > > Please make this 3. Otherwise no objections. The hardware supports both polarities. Currently I have added support for normal polarity. Subsequent patch will enable inverse polarity. Am I missing something here? Please let me know. Or since it is optional, there is no harm in making it to 3 to take care of any future additions in pwm.h flags. Cheers, Biju
