Hi Niklas, On Tue, Nov 5, 2024 at 2:39 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > This series wires up the MAX96724 on Gray-Hawk. All dependencies in > bindings and drivers are now in the media next tree. > > This targets the single board schematics but I opted to keep this in a > separate DTSI file as we do have a ID eeprom similar to what we have > setups where multiple boards. If you truly dislike this I can move it > into the 8a779h0-gray-hawk-single.dts. In that case would you prefers me > to drop the ID eeprom? I would say only use a separate file if you can (eventually) merge\ the White and Gray Hawk CSI/DSI .dtsi files. But given White Hawk uses MAX96712s and C-PHYs, while Gray Hawk uses MAX9724s and D-PHYs, I guess that is no longer an option to consider? Differences: - C vs. D-PHY, - data-lanes, - remote-endpoint (could be handled by using the same name), - compatible value, - (multiple unit-addresses) and reg values. which is a bit too much to handle through #defines. The ID EEPROM is present on both quad and single boards, so please keep it. Does that make sense? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds