Hi Krzysztof, Thank you for your review. > On 27/11/2024 16:19, Bhavin Sharma wrote: > > + > > +allOf: > > + - $ref: power-supply.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - st,stc3117 > > + > > + reg: > > + maxItems: 1 > > I asked you some questions on v2, then on v3 and no responses. I sincerely apologize for not addressing your questions in versions 2 and 3 of the patch. Regarding the battery configuration, we need the following information: - Battery capacity - Battery impedance - OCV curve - Minimum and maximum voltage - Current sense register Currently, I have set the battery capacity and impedance directly in the driver as default values. However, I understand these should ideally be defined in the device tree source (DTS). I will update the DTS accordingly to include these parameters. Additionally, since the OCV curve, minimum/maximum voltage, and sense register values are fixed, I would like your opinion on whether these should also be defined in the DTS or if it is acceptable to keep them in the driver itself. Once again, I apologize for the oversight and thank you for your understanding. Best regards, Bhavin ________________________________________ From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Sent: Wednesday, November 27, 2024 11:52 PM To: Bhavin Sharma <bhavin.sharma@xxxxxxxxxxxxxxxxx>; sre@xxxxxxxxxx <sre@xxxxxxxxxx>; krzk+dt@xxxxxxxxxx <krzk+dt@xxxxxxxxxx>; robh@xxxxxxxxxx <robh@xxxxxxxxxx>; conor+dt@xxxxxxxxxx <conor+dt@xxxxxxxxxx> Cc: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx <linux-pm@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx> Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On 27/11/2024 16:19, Bhavin Sharma wrote: > + > +allOf: > + - $ref: power-supply.yaml# > + > +properties: > + compatible: > + enum: > + - st,stc3117 > + > + reg: > + maxItems: 1 I asked you some questions on v2, then on v3 and no responses. You implemented some changes but still did not answer my question. I am not going to ask again, obviously expecting different result on the same makes little sense. No ack from me. Best regards, Krzysztof
