On 28/11/2024 08:49, Sean Nyekjaer wrote: > Hi Krzysztof, > > On Thu, Nov 28, 2024 at 08:31:41AM +0100, Krzysztof Kozlowski wrote: >> On 28/11/2024 08:09, Sean Nyekjaer wrote: >>> tcan4x5x requires an external clock called cclk, add it here. >> >> Nothing improved. Device already has this clock, so your rationale is >> not correct. > > Please explain, yes the device has this clock, but not the name. The > driver depends on the name. You say that the device - tcan4x5x - requires an external clock. This is already satisfied. > >> >> Also, offending patch is not in the next for some reason, so it should >> be squashed there. Conversion which leads to incorrect binding is not a >> correct conversion. > > "offending patch": > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?h=testing&id=77400284f54b9a1f6b6127c08cb935fc05e5c3d2 > > "dt-bindings: can: convert tcan4x5x.txt to DT schema" did the > conversion no more or less. > The original txt file fails to mention the clock required, > therefore IMHO this patch should be as a seperate patch :) Stop repeating the same as last time. No, I said it already multiple times in multiple threads, including guideline I gave some time ago: https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY You conversion is supposed to be complete and pass checks on existing DTS, which also implies matching driver. Best regards, Krzysztof
