Re: [PATCH v2 5/5] spi: bcm-mspi: Add support to set serial baud clock rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Apr 08, 2015 at 11:04:35AM -0700, Jonathan Richardson wrote:

> +	/*
> +	 * Enable clock if provided. The frequency can be changed by setting
> +	 * SPBR (serial clock baud rate) based on the desired 'clock-frequency'.
> +	 *
> +	 * Baud rate is calculated as: mspi_clk / (2 * SPBR) where SPBR is a
> +	 * value between 1-255. If not set then it is left at the h/w default.
> +	 */
> +	data->clk = devm_clk_get(dev, "mspi_clk");
> +	if (!IS_ERR(data->clk)) {

This is adding things to the DT binding, any new binding or binding
changes need to be documented.  It should also be paying attention to
errors rather than silently ignoring them, at least -EPROBE_DEFER should
be handled properly.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux