Hi Haylen, kernel test robot noticed the following build warnings: [auto build test WARNING on 2d5404caa8c7bb5c4e0435f94b28834ae5456623] url: https://github.com/intel-lab-lkp/linux/commits/Haylen-Chu/dt-bindings-clock-spacemit-Add-clock-controllers-of-Spacemit-K1-SoC/20241128-101248 base: 2d5404caa8c7bb5c4e0435f94b28834ae5456623 patch link: https://lore.kernel.org/r/20241126143125.9980-7-heylenay%404d2.org patch subject: [PATCH v3 3/3] clk: spacemit: Add clock support for Spacemit K1 SoC config: arm-randconfig-001-20241128 (https://download.01.org/0day-ci/archive/20241128/202411281451.lC2FKL6C-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411281451.lC2FKL6C-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411281451.lC2FKL6C-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/clk/spacemit/ccu_pll.c:128:16: warning: variable 'old_rate' set but not used [-Wunused-but-set-variable] 128 | unsigned long old_rate; | ^ >> drivers/clk/spacemit/ccu_pll.c:152:2: warning: variable 'val' is uninitialized when used here [-Wuninitialized] 152 | val |= entry->reg5 << PLL_SWCR1_REG5_OFF; | ^~~ drivers/clk/spacemit/ccu_pll.c:130:15: note: initialize the variable 'val' to silence this warning 130 | u32 mask, val; | ^ | = 0 >> drivers/clk/spacemit/ccu_pll.c:141:14: warning: variable 'entry' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized] 141 | for (i = 0; i < params->tbl_size; i++) { | ^~~~~~~~~~~~~~~~~~~~ drivers/clk/spacemit/ccu_pll.c:152:9: note: uninitialized use occurs here 152 | val |= entry->reg5 << PLL_SWCR1_REG5_OFF; | ^~~~~ drivers/clk/spacemit/ccu_pll.c:141:14: note: remove the condition if it is always true 141 | for (i = 0; i < params->tbl_size; i++) { | ^~~~~~~~~~~~~~~~~~~~ drivers/clk/spacemit/ccu_pll.c:127:32: note: initialize the variable 'entry' to silence this warning 127 | struct ccu_pll_rate_tbl *entry; | ^ | = NULL 3 warnings generated. vim +/val +152 drivers/clk/spacemit/ccu_pll.c 115 116 /* 117 * pll rate change requires sequence: 118 * clock off -> change rate setting -> clock on 119 * This function doesn't really change rate, but cache the config 120 */ 121 static int ccu_pll_set_rate(struct clk_hw *hw, unsigned long rate, 122 unsigned long parent_rate) 123 { 124 struct ccu_pll *p = hw_to_ccu_pll(hw); 125 struct ccu_common *common = &p->common; 126 struct ccu_pll_config *params = &p->pll; 127 struct ccu_pll_rate_tbl *entry; > 128 unsigned long old_rate; 129 bool found = false; 130 u32 mask, val; 131 int i; 132 133 if (ccu_pll_is_enabled(hw)) { 134 pr_err("%s %s is enabled, ignore the setrate!\n", 135 __func__, __clk_get_name(hw->clk)); 136 return 0; 137 } 138 139 old_rate = __get_vco_freq(hw); 140 > 141 for (i = 0; i < params->tbl_size; i++) { 142 if (rate == params->rate_tbl[i].rate) { 143 found = true; 144 entry = ¶ms->rate_tbl[i]; 145 break; 146 } 147 } 148 WARN_ON_ONCE(!found); 149 150 mask = PLL_SWCR1_REG5_MASK | PLL_SWCR1_REG6_MASK; 151 mask |= PLL_SWCR1_REG7_MASK | PLL_SWCR1_REG8_MASK; > 152 val |= entry->reg5 << PLL_SWCR1_REG5_OFF; 153 val |= entry->reg6 << PLL_SWCR1_REG6_OFF; 154 val |= entry->reg7 << PLL_SWCR1_REG7_OFF; 155 val |= entry->reg8 << PLL_SWCR1_REG8_OFF; 156 ccu_update(swcr1, common, mask, val); 157 158 mask = PLL_SWCR3_DIV_INT_MASK | PLL_SWCR3_DIV_FRC_MASK; 159 val = entry->div_int << PLL_SWCR3_DIV_INT_OFF; 160 val |= entry->div_frac << PLL_SWCR3_DIV_FRC_OFF; 161 ccu_update(swcr3, common, mask, val); 162 163 return 0; 164 } 165 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
