On Wed, Nov 27, 2024 at 12:34:42PM +0000, Biju Das wrote: > Hi Conor Dooley, > > Thanks for the feedback. > > > -----Original Message----- > > From: Conor Dooley <conor@xxxxxxxxxx> > > Sent: 25 November 2024 18:52 > > Subject: Re: [PATCH 03/12] dt-bindings: soc: renesas: Document RZ/G3E SMARC SoM and Carrier-II EVK > > > > On Fri, Nov 22, 2024 at 12:45:39PM +0000, Biju Das wrote: > > > Document the Renesas RZ/G3E SMARC Carrier-II EVK board which is based > > > on the Renesas RZ/G3E SMARC SoM. The RZ/G3E SMARC Carrier-II EVK > > > consists of an RZ/G3E SoM module and a SMARC Carrier-II carrier board. > > > The SoM module sits on top of the carrier board. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > > > b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > > > index 7cc2bb97db13..1785142fc8da 100644 > > > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > > > @@ -527,6 +527,10 @@ properties: > > > > > > - description: RZ/G3E (R9A09G047) > > > items: > > > + - enum: > > > + - renesas,smarc2-evk # RZ SMARC Carrier-II EVK > > > + - enum: > > > + - renesas,rzg3e-smarcm # RZ/G3E SMARC Module (SoM) > > > > Why are these enums, when you have a single item in each? > > I just followed the style used in [1] > > [1] https://elixir.bootlin.com/linux/v6.12.1/source/Documentation/devicetree/bindings/soc/renesas/renesas.yaml#L531 It ain't the same though, since you additionally have the SoM. > Other than that, > > In future some vendors can add their RZ/G3E SoM's here Only makes sense if their SoM is compatible with the smarc2-evk. > Or > > They can use Renesas RZ/G3E SMARC module and use their custom carrier boards. But allowing this part does make sense. > > Cheers, > Biju > > > > > > - enum: > > > - renesas,r9a09g047e58 # Quad Cortex-A55 + Cortex-M33 + Ethos-U55 (21mm BGA) > > > - renesas,r9a09g047e57 # Quad Cortex-A55 + Cortex-M33 + > > > Ethos-U55 (15mm BGA) > > > -- > > > 2.43.0 > > >
Attachment:
signature.asc
Description: PGP signature
