Re: [PATCH] [RFC] OF: probe order dependency aware of_platform_populate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Apr 8, 2015 at 9:43 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Apr 8, 2015 at 4:17 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
>>> Then we have dma controllers needing to be registered at subsys_initcall() for obvious reasons.
>>
>> These should be fixable with deferred probe. That requires fixing all
>> the client drivers where as fixing the dependencies would not need
>> driver changes.
>
> DMA is tricky in that there are three cases, not two:
>   1. DMA engine is available,
>   2. DMA engine is not yet available (e.g. DMA engine driver is modular),
>   3. DMA engine will never be available (DMA engine or DMA engine driver
>      not available).
>
> Case 2 is the tricky one: probably you don't want the client driver to
> fail hard,
> but want to fall back to PIO, and try to setup DMA again later.

Yes, we had just this case on the pl011 driver recently. In that case
we fixed it by moving the DMA setup to port open/init from probe.

But generically, dependency tracking is not going to have any way to know this.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux