On 08/04/15 16:31, Jacek Anaszewski wrote: > Properties defining maximum values for LED currents and timeout should > be mandatory to avoid the risk of hardware damage. This patch fixes > the issue. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/leds/common.txt | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 747c538..e478ac6 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -10,6 +10,17 @@ can influence the way of the LED device initialization, the LED components > have to be tightly coupled with the LED device binding. They are represented > by child nodes of the parent LED device binding. > > +Required properties for child nodes: These properties are mandatory only for LEDs with Flash/Torch capabilities, aren't they? Requiring those properties for all led nodes would make all current dtses not compliant with the DT binding specification AFAICT. How about: "Required properties for child nodes for LEDs with Flash/Torch capabilities:" ? > +- led-max-microamp : Maximum LED supply current in microamperes > + (torch LED for flash devices). Controllers that have no > + configurable current can omit this property. > +- flash-max-microamp : Maximum flash LED supply current in microamperes. > +- flash-timeout-us : Timeout in microseconds after which the flash > + LED is turned off. > + > +Above properties determine a LED driver IC settings required for safe > +operation. They should be also used as the initial settings for the IC. Shouldn't "Controllers that have no configurable current can omit this property" refer to both led-max-microamp and flash-max-microamp? I would drop the "Above...for the IC." paragraph and instead add something like: "For controllers that have no configurable current the led-max-microamp, flash-max-microamp properties respectively can be omitted. For controllers that have no configurable timeout the flash-timeout-us property can be omitted." -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
