Hey Conor, Am Dienstag, 26. November 2024, 18:44:14 CET schrieb Conor Dooley: > On Tue, Nov 26, 2024 at 02:17:34PM +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@xxxxxxxxx> > > > > Add dt-binding schema for the MIPI C-/D-PHY found on > > Rockchip RK3588 SoCs. > > > > Tested-by: Daniel Semkowicz <dse@xxxxxxxxxxxxx> > > Tested-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > > Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxxxxx> > > --- > > .../phy/rockchip,rk3588-mipi-dcphy.yaml | 87 +++++++++++++++++++ > > 1 file changed, 87 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > > new file mode 100644 > > index 000000000000..c8ff5ba22a86 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.yaml > > @@ -0,0 +1,87 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/rockchip,rk3588-mipi-dcphy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip MIPI D-/C-PHY with Samsung IP block > > + > > +maintainers: > > + - Guochun Huang <hero.huang@xxxxxxxxxxxxxx> > > + - Heiko Stuebner <heiko@xxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - rockchip,rk3576-mipi-dcphy > > + - rockchip,rk3588-mipi-dcphy > > How many phys do each of these SoCs have? - rk3588 has two - each with a separate GRF for additional settings [0] - rk3576 has one Heiko [0] https://lore.kernel.org/lkml/D5F5C1RWVHG5.TSHPO29TXYEF@xxxxxxxxx/T/ The register layout in each GRF area is identical, but each DC-PHY gets its own separate GRF io-mem block.