On 26/11/2024 12:18, Jason Hsu wrote: > Add Linux device tree related to Meta(Facebook) Ventura specific devices connected to BMC(AST2600) SoC. > Add subject prefix for the patch. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../aspeed/aspeed-bmc-facebook-ventura.dts | 883 ++++++++++++++++++ > 2 files changed, 884 insertions(+) > create mode 100644 arch/arm/bo > + led-2 { > + label = "bmc_ready_noled"; > + default-state = "on"; > + gpios = <&gpio0 ASPEED_GPIO(B, 3) (GPIO_ACTIVE_HIGH|GPIO_TRANSITORY)>; > + }; > + > + led-3 { > + label = "power_blue"; > + default-state = "off"; > + gpios = <&gpio0 ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>; > + }; > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + > + p1v8_bmc_aux: regulator-p1v8-bmc-aux { Fix indentation everywhere. It's broken in multiple places. Best regards, Krzysztof
