On 11/26/24 2:59 PM, Philipp Zabel wrote: > On Mo, 2024-11-25 at 22:07 +0530, Parthiban Nallathambi wrote: >> On some platforms like Allwinner A133 with GE8300 includes >> reset control from reset control unit. Add reset control >> optionally from the devicetree. >> >> Signed-off-by: Parthiban Nallathambi <parthiban@xxxxxxxxxxx> >> --- >> drivers/gpu/drm/imagination/pvr_device.h | 8 ++++++++ >> drivers/gpu/drm/imagination/pvr_drv.c | 5 +++++ >> drivers/gpu/drm/imagination/pvr_power.c | 16 +++++++++++++++- >> 3 files changed, 28 insertions(+), 1 deletion(-) Thanks for the reviews. As with the binding patch comments, reset control needs to be added together with the consumer i.e in this case GE8300 GPU in Allwinner A133 SoC. I will address the comments when sending patch with support for GE8300. Thanks, Parthiban
