On 11/25/24 11:37 PM, Conor Dooley wrote: > On Mon, Nov 25, 2024 at 10:07:03PM +0530, Parthiban Nallathambi wrote: >> GE8300 in Allwinner A133 have reset control from the ccu. >> Add the resets property as optional one to control it. > > There's no specific compatible here for an a133, but the binding > requires one. Where is your dts patch? A133 GPU is still work in progress in both Kernel and Mesa3D. Also power domain support needs an additional driver. But reset control is independent of those changes. Should reset control needs to be clubbed GPU dts changes? Thanks, Parthiban > >> >> Signed-off-by: Parthiban Nallathambi <parthiban@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml >> index 256e252f8087..bb607d4b1e07 100644 >> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml >> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml >> @@ -37,6 +37,9 @@ properties: >> power-domains: >> maxItems: 1 >> >> + resets: >> + maxItems: 1 >> + >> required: >> - compatible >> - reg >> >> -- >> 2.39.2 >>
