On 11/20/2024 12:17 AM, Krzysztof Kozlowski wrote:
On Mon, Nov 11, 2024 at 04:28:04PM -0800, Melody Olvera wrote:
From: Taniya Das <quic_tdas@xxxxxxxxxxx>
Add bindings documentation for the SM8750 General Clock Controller.
Subject prefix - use proper file prefix:
dt-bindings: clock: qcom,sm8650-gcc:
Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx>
---
.../bindings/clock/qcom,sm8650-gcc.yaml | 8 +-
include/dt-bindings/clock/qcom,sm8750-gcc.h | 226 ++++++++++++++++++
2 files changed, 232 insertions(+), 2 deletions(-)
create mode 100644 include/dt-bindings/clock/qcom,sm8750-gcc.h
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
index 976f29cce809..e50b5f1cad75 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
@@ -13,11 +13,15 @@ description: |
Qualcomm global clock control module provides the clocks, resets and power
domains on SM8650
- See also:: include/dt-bindings/clock/qcom,sm8650-gcc.h
+ See also: include/dt-bindings/clock/qcom,sm8650-gcc.h
+ include/dt-bindings/reset/qcom,sm8750-gcc.h
properties:
compatible:
- const: qcom,sm8650-gcc
+ items:
No need for items, simpler is just enum.
+ - enum:
+ - qcom,sm8650-gcc
+ - qcom,sm8750-gcc
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Hey Krzysztof; I want to draw you attention to the discussion on patch
v2 5/7 of this series;
We realized these bindings don't match with the driver; notably SM8750
doesn't have the
pcie1 clocks available on SM8650. To this end, it seems prudent to bring
back the separate
bindings file from ps 1.
Thanks,
Melody
