On 25/11/2024 15:14, Hector Martin wrote: >>> + >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 0 >>> + >>> +additionalProperties: true >> >> This cannot be true. Must be false. >> >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >> >> This goes before additionalProperties. >> >> Missing example: that's a strong NAK and prove that this could not be >> even tested. >> >> Do you see any device schema without example? No. Do not develop things >> differently, Apple is not unique, special or exceptional. > > Krzysztof, it is entirely possible to express this same feedback without > being condescending and rude. I'm pretty sure you can do better than this. Please kindly trim the replies from unnecessary context. It makes it much easier to find new content. Instead of patronizing, note that this was just pure observation - this was done entirely than other bindings, which should be taken as an example. Or example-schema should be taken as example... Pointing out issues and inconsistencies is not rude or condescending. Basically now you are condescending people's feedback which further restricts review process allowing comments which you approve. You got here one day review, enjoy that. Best regards, Krzysztof
