Re: [PATCH v5 2/5] media: qcom: camss: Sort camss version enums and compatible strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/2024 17:30, Vikram Sharma wrote:
Sort CAMSS version enums and compatible strings alphanumerically.

Signed-off-by: Suresh Vankadara <quic_svankada@xxxxxxxxxxx>
Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@xxxxxxxxxxx>
Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
---
  .../media/platform/qcom/camss/camss-csiphy-3ph-1-0.c   | 10 +++++-----
  drivers/media/platform/qcom/camss/camss-vfe.c          |  6 +++---
  drivers/media/platform/qcom/camss/camss.c              |  2 +-
  drivers/media/platform/qcom/camss/camss.h              |  4 ++--
  4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index df7e93a5a4f6..7d2490c9de01 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -505,10 +505,6 @@ static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy,
  	u32 val;
switch (csiphy->camss->res->version) {
-	case CAMSS_845:
-		r = &lane_regs_sdm845[0][0];
-		array_size = ARRAY_SIZE(lane_regs_sdm845[0]);
-		break;
  	case CAMSS_8250:
  		r = &lane_regs_sm8250[0][0];
  		array_size = ARRAY_SIZE(lane_regs_sm8250[0]);
@@ -517,6 +513,10 @@ static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy,
  		r = &lane_regs_sc8280xp[0][0];
  		array_size = ARRAY_SIZE(lane_regs_sc8280xp[0]);
  		break;
+	case CAMSS_845:
+		r = &lane_regs_sdm845[0][0];
+		array_size = ARRAY_SIZE(lane_regs_sdm845[0]);
+		break;
  	default:
  		WARN(1, "unknown cspi version\n");
  		return;
@@ -557,9 +557,9 @@ static bool csiphy_is_gen2(u32 version)
  	bool ret = false;
switch (version) {
-	case CAMSS_845:
  	case CAMSS_8250:
  	case CAMSS_8280XP:
+	case CAMSS_845:
  		ret = true;
  		break;
  	}
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index d801275228b0..f9e64cbacb20 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -334,11 +334,11 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
  			return sink_code;
  		}
  		break;
-	case CAMSS_8x96:
  	case CAMSS_660:
-	case CAMSS_845:
+	case CAMSS_8x96:
  	case CAMSS_8250:
  	case CAMSS_8280XP:
+	case CAMSS_845:
  		switch (sink_code) {
  		case MEDIA_BUS_FMT_YUYV8_1X16:
  		{
@@ -1693,9 +1693,9 @@ static int vfe_bpl_align(struct vfe_device *vfe)
  	int ret = 8;
switch (vfe->camss->res->version) {
-	case CAMSS_845:
  	case CAMSS_8250:
  	case CAMSS_8280XP:
+	case CAMSS_845:
  		ret = 16;
  		break;
  	default:
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 12778846b2ca..2d8efed51912 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -2692,10 +2692,10 @@ static const struct of_device_id camss_dt_match[] = {
  	{ .compatible = "qcom,msm8916-camss", .data = &msm8916_resources },
  	{ .compatible = "qcom,msm8953-camss", .data = &msm8953_resources },
  	{ .compatible = "qcom,msm8996-camss", .data = &msm8996_resources },
+	{ .compatible = "qcom,sc8280xp-camss", .data = &sc8280xp_resources },
  	{ .compatible = "qcom,sdm660-camss", .data = &sdm660_resources },
  	{ .compatible = "qcom,sdm845-camss", .data = &sdm845_resources },
  	{ .compatible = "qcom,sm8250-camss", .data = &sm8250_resources },
-	{ .compatible = "qcom,sc8280xp-camss", .data = &sc8280xp_resources },
  	{ }
  };
diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
index c50cf7dc81f2..bdc11d6d2203 100644
--- a/drivers/media/platform/qcom/camss/camss.h
+++ b/drivers/media/platform/qcom/camss/camss.h
@@ -77,13 +77,13 @@ enum pm_domain {
  };
enum camss_version {
+	CAMSS_660,
  	CAMSS_8x16,
  	CAMSS_8x53,
  	CAMSS_8x96,
-	CAMSS_660,
-	CAMSS_845,
  	CAMSS_8250,
  	CAMSS_8280XP,
+	CAMSS_845,
  };
enum icc_count {

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux