On Fri, Nov 22, 2024 at 10:25:43PM +0200, Andy Shevchenko wrote: > On Fri, Nov 22, 2024 at 1:34 PM Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxx> wrote: > > > > A driver that silently fails to probe is annoying and hard to debug. So > > add messages in the error paths of the probe function. > > ... > > > +/* Only called during probe, so dev_err_probe() can be used */ > > It's a harmless comment, but I think dev_err_probe() name is good > enough to give such a hint. Seems to be subjective. I guess I found already too many functions using dev_err_probe() that are called also after .probe(). > > ret = ad7124_soft_reset(st); > > if (ret < 0) > > > + /* ad7124_soft_reset() already emitted an error message */ > > To me it looks like an almost useless comment. Same as above. If one of the first thoughts when you look at this code is: "Huh, no error message in this exit code", it helps. I ignored your side notes for now as they wouldn't affect this patch. I made a note for later however. Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
