On 25/11/2024 10:21, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> Why this tag stayed and other was removed? What was the reason of tag removal? > --- > Changelog v2: > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > > Changelog v5: > - no change > > Changelog v6: > - add register definition of BUS-IF and MPU > > Changelog v7: > - remove trailing "bindings" from commit header message > - remove trailing "Device Tree Bindings" from title > - fix text wrapping of description > - change compatible to visconti5-viif > - explicitly define allowed properties for port::endpoint > > Changelog v8: > - Suggestion from Krzysztof Kozlowski > - rename bindings description file > - use block style array instead of inline style > - remove clock-lane (as it is fixed at position 0) > - update sample node's name > - use lowercase hex for literals > - Suggestion from Laurent Pinchart > - update description message port::description > - remove port::endpoint::bus-type as it is fixed to <4> > - remove port::endpoint::clock-lanes from example > - add port::endpoint::data-lanes to required parameters list > - fix sequence of data-lanes: <1 2 3 4> because current driver does not support data reordering > - update port::endpoint::data-lanes::description > - remove redundant type definition for port::endpoint::data-lanes > > Changelog v9: > - place "required" after "properties" > - dictionary ordering of properties > > Changelog v10: > - no change > > Changelog v11: > - no change > > Changelog v12: > - remove property "clock-noncontinuous" as VIIF switches both modes automatically > - remove property "link-frequencies" as VIIF does not use the information Driver does not use or hardware supports only one frequency? > - remove reg[2] and interrupts[3] which are used for CSI2RX driver > - update example to refer csi2rx for remote-endpoint Were these the reasons? I am really surprised that after 11 versions this binding still is being totally reshaped and you need us to re-review. Also, start using b4 tool, so: 1. your cover letter will have proper links to previous versions 2. b4 diff would work. Look, try by yourself: b4 diff '<20241125092146.1561901-3-yuji2.ishikawa@xxxxxxxxxxxxx>' Grabbing thread from lore.kernel.org/all/20241125092146.1561901-3-yuji2.ishikawa@xxxxxxxxxxxxx/t.mbox.gz Checking for older revisions Grabbing search results from lore.kernel.org Added from v11: 7 patches --- Analyzing 144 messages in the thread Looking for additional code-review trailers on lore.kernel.org Analyzing 13 code-review messages Preparing fake-am for v11: Add Toshiba Visconti Video Input Interface driver range: e16e149ced15..4efb0d6768a6 Preparing fake-am for v12: dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver ERROR: v12 series incomplete; unable to create a fake-am range --- Could not create fake-am range for upper series v12 How can I verify what happened here without too much effort? > > .../media/toshiba,visconti5-viif.yaml | 95 +++++++++++++++++++ > 1 file changed, 95 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml > new file mode 100644 > index 000000000000..ef0452a47e98 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti5-viif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC Video Input Interface > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > + > +description: |- Since you ask for re-review, then: Drop |- Best regards, Krzysztof
