On 2024/11/25 16:06, Krzysztof Kozlowski wrote: > On 25/11/2024 07:49, Troy Mitchell wrote: >> Hi all, >> >> This patch implements I2C driver for the SpacemiT K1 SoC, >> providing basic support for I2C read/write communication which >> compatible with standard I2C bus specifications. >> >> In this version, the driver defaults to use fast-speed-mode and >> interrupts for transmission, and does not support DMA, high-speed mode, or FIFO. >> >> The docs of I2C can be found here, in chapter 16.1 I2C [1] >> >> Link: https://developer.spacemit.com/documentation?token=Rn9Kw3iFHirAMgkIpTAcV2Arnkf#part5 [1] >> --- >> Change in v4: >> - Patch #1: >> - Change the default value of clock-frequency from 100000 to >> 400000. This is to correspond to the driver's default value. >> - Drop the minimum of clock-frequency >> - Modify the description of clock-frequency > > Explain why do you request re-review. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof Thank you, I accidentally forgot to add it, and it was not intentional. -- Troy Mitchell
