On Mon, Nov 25, 2024 at 11:04:49AM +0530, Renjiang Han wrote: > Add support for Qualcomm video acceleration hardware used for video > stream decoding and encoding on QCOM QCS615. > > Signed-off-by: Renjiang Han <quic_renjiang@xxxxxxxxxxx> > --- > .../bindings/media/qcom,qcs615-venus.yaml | 182 +++++++++++++++++++++ > 1 file changed, 182 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,qcs615-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcs615-venus.yaml Dependency for this patch must be mentioned here. Amount of dependencies make it unmergeable and untesteable. I suggest decoupling dependencies by removing clock constants. > new file mode 100644 > index 0000000000000000000000000000000000000000..7a3a01ff06d8b62bc2424a0a24857c86c6865f89 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,qcs615-venus.yaml > @@ -0,0 +1,182 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,qcs615-venus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm QCS615 Venus video encode and decode accelerators > + > +maintainers: > + - Stanimir Varbanov <stanimir.k.varbanov@xxxxxxxxx> > + - Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> > + > +description: > + The Venus IP is a video encode and decode accelerator present > + on Qualcomm platforms > + > +allOf: > + - $ref: qcom,venus-common.yaml# > + > +properties: > + compatible: > + const: qcom,qcs615-venus > + > + power-domains: > + minItems: 2 > + maxItems: 3 > + > + power-domain-names: > + minItems: 2 > + items: > + - const: venus > + - const: vcodec0 > + - const: cx > + > + clocks: > + maxItems: 5 > + > + clock-names: > + items: > + - const: core > + - const: iface > + - const: bus > + - const: vcodec0_core > + - const: vcodec0_bus > + > + iommus: > + maxItems: 1 > + > + memory-region: > + maxItems: 1 > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + items: > + - const: video-mem > + - const: cpu-cfg > + > + operating-points-v2: true > + > + opp-table: > + type: object > + > + video-decoder: > + type: object > + > + additionalProperties: false > + > + properties: > + compatible: > + const: venus-decoder > + > + required: > + - compatible > + > + video-encoder: > + type: object Both nodes are useless - no resources here, nothing to control. Do not add nodes just to instantiate Linux drivers. Drop them. Best regards, Krzysztof
