On Tue, Mar 31, 2015 at 2:37 AM, Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx> wrote: > Add compatible string definitions and supported pin functions. > > Signed-off-by: Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx> > --- [..] > diff --git a/include/dt-bindings/pinctrl/qcom,pmic-gpio.h b/include/dt-bindings/pinctrl/qcom,pmic-gpio.h [..] > > +#define PM8916_GPIO1_BAT_ALRM_OUT PMIC_GPIO_FUNC_FUNC1 > +#define PM8916_GPIO1_KEYP_DRV PMIC_GPIO_FUNC_FUNC2 > +#define PM8916_GPIO2_DIV_CLK PMIC_GPIO_FUNC_FUNC1 > +#define PM8916_GPIO2_SLEEP_CLK PMIC_GPIO_FUNC_FUNC2 > +#define PM8916_GPIO3_KEYP_DRV PMIC_GPIO_FUNC_FUNC1 > +#define PM8916_GPIO4_KEYP_DRV PMIC_GPIO_FUNC_FUNC2 > + The documentation I have for the PM8916 is vague, but lists slightly different functions. Andy, could you help out with verifying the functions of the gpios on this pmic? For the rest of the patch: Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
