On Tue, Apr 7, 2015 at 10:16 AM, James Hartley <James.Hartley@xxxxxxxxxx> wrote: > > >> -----Original Message----- >> From: abrestic@xxxxxxxxxx [mailto:abrestic@xxxxxxxxxx] On Behalf Of >> Andrew Bresticker >> Sent: 06 April 2015 23:28 >> To: Arnd Bergmann; James Hartley >> Cc: David S. Miller; Giuseppe Cavallaro; devicetree@xxxxxxxxxxxxxxx; >> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Govindraj Raja >> Subject: Re: [PATCH V2 2/2] stmmac: Add IMG Pistachio platform glue layer >> >> On Mon, Apr 6, 2015 at 3:10 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> > On Monday 06 April 2015 14:42:38 Andrew Bresticker wrote: >> >> At the moment, the only additional setup required for the DWMAC on >> >> the IMG Pistachio SoC is to request and enable a separate gate clock >> >> for the register interface. >> >> >> >> Signed-off-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> >> >> Signed-off-by: Govindraj Raja <govindraj.raja@xxxxxxxxxx> >> >> Cc: James Hartley <james.hartley@xxxxxxxxxx> >> > >> > Why do you need a special glue driver for that? >> > >> > Since you don't do anything special, I'd say it should be possible to >> > handle this with just the default driver. >> >> Right, at the moment we only need to request and enable a second clock, >> which could be added to the core driver. If we don't expect to have to >> extend this driver to deal with other configurations (which IIRC there were >> some concerns about when I wrote this), then I'm fine with folding this change >> into the core driver - James? > > Weren't the concerns about USB not Ethernet? I don't remember anything that > would stop us extending the driver for eth. OK, let's try this then: https://patchwork.kernel.org/patch/6174881/ -Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
