Re: [PATCH 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 22, 2024 at 11:47:22AM +0800, Sung-Chi Li wrote:
> The cros_ec supports limiting the input current to act as a passive
> thermal cooling device. Add the property '#cooling-cells' bindings, such
> that thermal framework can recognize cros_ec as a valid thermal cooling
> device.
> 
> Signed-off-by: Sung-Chi Li <lschyi@xxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index aac8819bd00b..2b6f098057af 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -96,6 +96,9 @@ properties:
>    '#gpio-cells':
>      const: 2
>  
> +  '#cooling-cells':
> +    const: 2

This is not a cooling device. BTW, your commit msg is somehow circular.
"Add cooling to make it a cooling device because it will be then cooling
device."

Power supply already provides necessary framework for managing charging
current and temperatures. If this is to stay, you need to explain why
this is suitable to be considered a thermal zone or system cooling
device (not power supply or input power cooling).

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux