On Wed, Nov 20, 2024 at 02:40:41PM +0200, Dmitry Baryshkov wrote:
> On Tue, Nov 19, 2024 at 11:37:53AM +0530, Varadarajan Narayanan wrote:
> > The 'broadcast' register space is present only in chipsets that
> > have multiple instances of LLCC IP. Since IPQ5424 has only one
> > instance, both the LLCC and LLCC_BROADCAST points to the same
> > register space.
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > ---
> > v3: Rebase to ToT
> > Remove 'need_llcc_cfg = true'
> >
> > v2: Use 'true/false' instead of '1/0' for boolean variables.
> > Add 'no_broadcast_register' to qcom_llcc_config structure
> > to identify SoC without LLCC_BROADCAST register space instead
> > of using 'num_banks'.
> > ---
> > drivers/soc/qcom/llcc-qcom.c | 57 ++++++++++++++++++++++++++++++++++--
> > 1 file changed, 55 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> > index 32c3bc887cef..106f2619277a 100644
> > --- a/drivers/soc/qcom/llcc-qcom.c
> > +++ b/drivers/soc/qcom/llcc-qcom.c
[ . . . ]
> > /* Extract version of the IP */
> > @@ -4032,6 +4084,7 @@ static const struct of_device_id qcom_llcc_of_match[] = {
> > { .compatible = "qcom,qcs615-llcc", .data = &qcs615_cfgs},
> > { .compatible = "qcom,qcs8300-llcc", .data = &qcs8300_cfgs},
> > { .compatible = "qcom,qdu1000-llcc", .data = &qdu1000_cfgs},
> > + { .compatible = "qcom,ipq5424-llcc", .data = &ipq5424_cfgs},
>
> I wonder why is this getting inserted at this point. The list is sorted
> and your entry definitely is not in the correct place.
>
> Please review if your addition is breaking sorting order in other places
> too.
Sorry, have fixed this here and in the dt-bindings yaml file
and posted v4. Please review.
Thanks
Varada
> > { .compatible = "qcom,sa8775p-llcc", .data = &sa8775p_cfgs },
> > { .compatible = "qcom,sar1130p-llcc", .data = &sar1130p_cfgs },
> > { .compatible = "qcom,sar2130p-llcc", .data = &sar2130p_cfgs },
