On Tue, Nov 19, 2024 at 02:59:53AM +0000, Ming-Jen Chen wrote: > Add YAML bindings for MA35D1 SoC keypad. > > Signed-off-by: Ming-Jen Chen <mjchen0829@xxxxxxxxx> > --- > .../bindings/input/nuvoton,ma35d1-keypad.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml > new file mode 100644 > index 000000000000..9ccd81a2574d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml Filename matching compatible. You got this comment already. > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/nuvoton,ma35d1-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Keypad > + > +maintainers: > + - Ming-jen Chen <mjchen0829@xxxxxxxxx> > + > +allOf: > + - $ref: /schemas/input/matrix-keymap.yaml# > + > +properties: > + compatible: > + const: nuvoton,ma35d1-kpi > + > + debounce-delay-ms: > + description: Debounce delay time in milliseconds. > + maxItems: 1 > + > + scan-interval-ms: > + description: Scan interval time in milliseconds. > + maxItems: 1 > + > + reg: > + maxItems: 1 Keep the same order of properties as in required: block. > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - linux,keymap > + - keypad,num-rows > + - keypad,num-columns > + - debounce-delay-ms > + - scan-interval-ms > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/input/input.h> > + keypad@404A0000 { Lowercase hex > + compatible = "nuvoton,ma35d1-kpi"; > + reg = <0x404A0000 0x10000>; Lowercase hex Best regards, Krzysztof