On 18/11/2024 14:01, Matt Coster wrote: > Use the new compatible string introduced earlier (in "dt-bindings: gpu: > img: More explicit compatible strings") and add a name to the single power > domain for this GPU (introduced in "dt-bindings: gpu: img: Power domain > details"). > > Signed-off-by: Matt Coster <matt.coster@xxxxxxxxxx> > --- > Changes in v2: > - None > - Link to v1: https://lore.kernel.org/r/20241105-sets-bxs-4-64-patch-v1-v1-7-4ed30e865892@xxxxxxxxxx Do not mix DTS with code. It always goes either to end of patchset or entirely separate. To be clear: this cannot be merged into DRM. > --- > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > index 5b92aef5b284b78749a01d44184b66e7776a124d..93dcc67c3138ad5b4a7ad6c9bcabb71a2b7e408d 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > @@ -693,12 +693,13 @@ ospi0: spi@fc40000 { > }; > > gpu: gpu@fd00000 { > - compatible = "ti,am62-gpu", "img,img-axe"; > + compatible = "ti,am62-gpu", "img,img-axe-1-16m", "img,img-rogue"; Definitely NAK, breaks users and nothing in commit msg provides any help on that, including why or how it affects potential users. Best regards, Krzysztof
