On Sat, Nov 16, 2024 at 01:54:23AM +0200, Dmitry Baryshkov wrote: > On Sat, Nov 16, 2024 at 04:21:52AM +0530, Wasim Nazir wrote: > > Add device tree support for QCS9075 Ride & Ride-r3 boards. > > QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > > boards but without safety monitoring feature of SAfety-IsLand > > subsystem. > > Why do we need another set of DTS files? Should we expect more changes > to these DTS files? Ride/r3 based on qcs9075 and qcs9100 are 4 different boards with different SoCs, so different file is used to represent all the 4 boards. > > > > > Difference between ride and ride-r3 is the ethernet phy. > > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > > > Signed-off-by: Wasim Nazir <quic_wasimn@xxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 2 ++ > > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > > 3 files changed, 26 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 5d9847119f2e..91c811aca2ca 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > new file mode 100644 > > index 000000000000..a04c8d1fa258 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > @@ -0,0 +1,12 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > +/dts-v1/; > > + > > +#include "sa8775p-ride-r3.dts" > > + > > +/ { > > + model = "Qualcomm Technologies, Inc. QCS9075 Ride Rev3"; > > + compatible = "qcom,qcs9075-ride-r3", "qcom,qcs9075", "qcom,sa8775p"; > > +}; > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > new file mode 100644 > > index 000000000000..9ffab74fb1a8 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > @@ -0,0 +1,12 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > +/dts-v1/; > > + > > +#include "sa8775p-ride.dts" > > + > > +/ { > > + model = "Qualcomm Technologies, Inc. QCS9075 Ride"; > > + compatible = "qcom,qcs9075-ride", "qcom,qcs9075", "qcom,sa8775p"; > > +}; > > -- > > 2.47.0 > > > > -- > With best wishes > Dmitry Thanks & Regards, Wasim