On 2024-10-30 at 14:41 +01, Andrew Lunn <andrew@xxxxxxx> wrote:
> +&gmac2 {
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <&emac2_phy0>;
> +
> + max-frame-size = <9000>;
> +
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + emac2_phy0: ethernet-phy@1 {
> + reg = <0x1>;
> + adi,rx-internal-delay-ps = <2000>;
> + adi,tx-internal-delay-ps = <2000>;
You have rgmii-id and 2000ps delay? Are these two lines actually
required?
The binding states that these lines are for rgmii-id (and rgmii-rxid) mode, so why not?
Or am I misunderstanding and you mean setting the default values here is unnecessary?
Best regards,
Steffen
--
Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
