Hi Arnd,
Thank you for you reply.
> > }
> >
> > if (priv->is_aspeed) {
> > + struct reset_control *rst;
> > +
> > err = ftgmac100_setup_clk(priv);
> > if (err)
> > goto err_phy_connect;
> >
> > + rst = devm_reset_control_get_optional(priv->dev, NULL);
> > + if (IS_ERR(rst))
> > + goto err_register_netdev;
> > + priv->rst = rst;
> > +
> > + err = reset_control_assert(priv->rst);
>
> Since that reset line is optional, how about making it part of the normal probe
> procedure, not just the if(aspeed) section? It seems this does nothing for older
> devices but may help for future ones regardless of the SoC family.
Agree.
Because it is optional, even if reset line does not exist on other SoCs, it will
not affect the behavior of the code.
Thank you for pointing this out.
I will adjust it to normal probe procedure in next version.
Or I will separate it from Aspeed AST2700 support series.
Jacky
