On Fri, Nov 15, 2024 at 05:40:23PM +0530, Ekansh Gupta wrote:
>
>
> On 11/14/2024 5:30 PM, Dmitry Baryshkov wrote:
> > On Thu, Nov 14, 2024 at 10:49:52AM +0530, Ekansh Gupta wrote:
> >>
> >> On 11/13/2024 5:20 PM, Dmitry Baryshkov wrote:
> >>> On Wed, 13 Nov 2024 at 08:18, Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx> wrote:
> >>>>
> >>>> On 11/13/2024 11:13 AM, Dmitry Baryshkov wrote:
> >>>>> On Wed, Nov 13, 2024 at 10:30:42AM +0530, Ekansh Gupta wrote:
[...]
> >>>>>>
> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> >>>>>> index 3d8410683402..c633926c0f33 100644
> >>>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> >>>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> >>>>>> @@ -3852,7 +3852,6 @@ fastrpc {
> >>>>>> compatible = "qcom,fastrpc";
> >>>>>> qcom,glink-channels = "fastrpcglink-apps-dsp";
> >>>>>> label = "adsp";
> >>>>>> - qcom,non-secure-domain;
> > - Are there other platforms which have this flag set for ADSP?
> Yes, there are a few platforms where this property is added for ADSP.
Please clean up all of them to reduce a possible chance of different behaviour or further c&p errors.
> > - Granted that sc7280 was targeting ChromeOS devices, might it be that
> > there is a CrOS-specific userspace for that?
> FastRPC nodes were recently added to this devicetree recently. Looks like this property is just getting copied.
> It might be that fastrpc was recently tried on ChromeOS device or it might be added to support some other devices
> that uses fastrpc(qcm6490-idp etc.).
Indeed.
Luca, could you possibly comment, as you've added ADSP / FastRPC nodes?
--
With best wishes
Dmitry
