Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Apr 6, 2015 at 9:40 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Sunday 05 April 2015 16:59:24 Geert Uytterhoeven wrote:
>> If CONFIG_IRQ_DOMAIN=n:
>>
>> drivers/of/irq.c: In function ‘of_irq_get’:
>> drivers/of/irq.c:406: error: implicit declaration of function ‘irq_find_host’
>> drivers/of/irq.c:406: warning: assignment makes pointer from integer without a cast
>> make[2]: *** [drivers/of/irq.o] Error 1
>>
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>>  drivers/of/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index 4c98f14694458794..92adecd3ecb28fc7 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI
>>
>>  config OF_IRQ
>>         def_bool y
>> -       depends on !SPARC
>> +       depends on !SPARC && IRQ_DOMAIN
>>
>>  config OF_NET
>>         depends on NETDEVICES
>>
>
> Sparc does not set IRQ_DOMAIN, so we can probably simplify this to
>
> config OF_IRQ
>         def_bool IRQ_DOMAIN
>
> unless you want to keep the sparc antidependency explicit.

IRQ_DOMAIN is selected in quite a few places. We'd need to make sure
none of those can be selected by Sparc.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux